-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspicious Loop Detector #206
Open
Esorat
wants to merge
18
commits into
nowarp:master
Choose a base branch
from
Esorat:171-suspicious-loop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+209
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 171-suspicious-loop
jubnzv
requested changes
Jan 23, 2025
Update Changelog
jubnzv
reviewed
Jan 24, 2025
…heck repeat/while/until per requirements
jubnzv
reviewed
Jan 25, 2025
jubnzv
reviewed
Jan 25, 2025
jubnzv
reviewed
Jan 25, 2025
stmt.kind === "statement_while" || | ||
stmt.kind === "statement_repeat" || | ||
stmt.kind === "statement_until" || | ||
stmt.kind === "statement_foreach" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not consider foreach
here
jubnzv
reviewed
Jan 25, 2025
* @param stmt - The statement to evaluate. | ||
* @returns True if the expression is suspicious, otherwise false. | ||
*/ | ||
private isSuspiciousCondition( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create two separate function to check integers and booleans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171
CHANGELOG.md
yarn test-all